compat/regex: move stdlib.h up in inclusion chain
commit3bc1f9e48cb9640c901d19f193f4417ca805a86a
authorĐoàn Trần Công Danh <congdanhqx@gmail.com>
Mon, 27 Apr 2020 14:22:35 +0000 (27 21:22 +0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 27 Apr 2020 18:21:16 +0000 (27 11:21 -0700)
tree3f8eaa9d1e7f68a13e6de85043626287ee5ca1ae
parent1437ebf74a4c37b5ddafc14d4cdb6caf95bd16c6
compat/regex: move stdlib.h up in inclusion chain

In Linux with musl libc, we have this inclusion chain:

compat/regex/regex.c:69
`-> compat/regex/regex_internal.h
   `-> /usr/include/stdlib.h
      `-> /usr/include/features.h
      `-> /usr/include/alloca.h

In that inclusion chain, `<features.h>` claims it's _BSD_SOURCE
compatible when it's NOT asked to be either
{_POSIX,_GNU,_XOPEN,_BSD}_SOURCE, or __STRICT_ANSI__.
And, `<stdlib.h>` will include `<alloca.h>` to be compatible with
software written for GNU and BSD. Thus, redefine `alloca` macro,
which was defined before at compat/regex/regex.c:66.

Considering this is only compat code, we've taken from other project,
it's not our business to decide which source should we adhere to.

Include `<stdlib.h>` early to prevent the redefinition of alloca.
This also remove a potential warning about alloca not defined on:
#undef alloca

Helped-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/regex/regex.c
compat/regex/regex_internal.h