| commit | 3699d69df0345309ba16b9c7fb43fd86a7595f58 | |
| author | Denton Liu <liu.denton@gmail.com> | |
| Wed, 4 Dec 2019 22:03:24 +0000 (4 14:03 -0800) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 4 Dec 2019 22:25:05 +0000 (4 14:25 -0800) | ||
| tree | 68614dbc8f792250d5e2be842fd11e9a10db4263 | treesnapshot (tar.gz zip) |
| parent | dcf9a748cabedd6353d411eb5119fbe7fdda6ff5 | commitdiff |
t7700: make references to SHA-1 generic
Make the test more hash-agnostic by renaming variables from "sha1" to
some variation of "oid" or "packid". Also, replace the regex,
`[0-9a-f]\{40\}` with `$OID_REGEX`.
A better name for "incrpackid" (incremental pack-id) might have been
just "packid". However, later in the test suite, we have other uses of
"packid". Although the scopes of these variables don't conflict, a
future developer may think that commit_and_pack() and
test_has_duplicate_object() are semantically related somehow since they
share the same variable name. Give them distinct names so that it's
clear these uses are unrelated.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Make the test more hash-agnostic by renaming variables from "sha1" to
some variation of "oid" or "packid". Also, replace the regex,
`[0-9a-f]\{40\}` with `$OID_REGEX`.
A better name for "incrpackid" (incremental pack-id) might have been
just "packid". However, later in the test suite, we have other uses of
"packid". Although the scopes of these variables don't conflict, a
future developer may think that commit_and_pack() and
test_has_duplicate_object() are semantically related somehow since they
share the same variable name. Give them distinct names so that it's
clear these uses are unrelated.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t7700-repack.sh | diffblobblamehistory |