| commit | 3324dd8f267cb59cdd42ac33727b6844921d5017 | |
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | |
| Wed, 29 Jun 2016 14:14:54 +0000 (29 16:14 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 29 Jun 2016 22:07:02 +0000 (29 15:07 -0700) | ||
| tree | 40bddd3eb8bb41fdd0724d4a6d24037be083a99e | treesnapshot (tar.gz zip) |
| parent | e46579643d56162299b1756b70d418005351b256 | commitdiff |
commit -S: avoid invalid pointer with empty message
While it is not recommended, fsck.c says:
Not having a body is not a crime [...]
... which means that we cannot assume that the commit buffer
contains an empty line to separate header from body. A commit
object with only a header without any body, not even without
a blank line after the header, is valid.
So let's tread carefully here. strstr("\n\n") may find nothing
and return NULL.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
While it is not recommended, fsck.c says:
Not having a body is not a crime [...]
... which means that we cannot assume that the commit buffer
contains an empty line to separate header from body. A commit
object with only a header without any body, not even without
a blank line after the header, is valid.
So let's tread carefully here. strstr("\n\n") may find nothing
and return NULL.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| commit.c | diffblobblamehistory |