t/chainlint: add chainlint "complex" test cases
commit1f718b0b78f4fe1b6686c6bbae4ec4859d240070
authorEric Sunshine <sunshine@sunshineco.com>
Wed, 11 Jul 2018 06:46:41 +0000 (11 02:46 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 17 Jul 2018 16:15:15 +0000 (17 09:15 -0700)
tree91450b1ff7d72a9c21c13b9c4c2bd75e1bf6db1f
parent24c86180649baec2dde4d5e5b6350d048f5d6bb3
t/chainlint: add chainlint "complex" test cases

The --chain-lint option uses heuristics and knowledge of shell syntax to
detect broken &&-chains in subshells by pure textual inspection. The
heuristics handle a range of stylistic variations in existing tests
(evolved over the years), however, they are still best-guesses. As such,
it is possible for future changes to accidentally break assumptions upon
which the heuristics are based. Protect against this possibility by
adding tests which check the linter itself for correctness.

In addition to protecting against regressions, these tests help document
(for humans) expected behavior, which is important since the linter's
implementation language ('sed') does not necessarily lend itself to easy
comprehension.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/chainlint/close-nested-and-parent-together.expect [new file with mode: 0644]
t/chainlint/close-nested-and-parent-together.test [new file with mode: 0644]
t/chainlint/complex-if-in-cuddled-loop.expect [new file with mode: 0644]
t/chainlint/complex-if-in-cuddled-loop.test [new file with mode: 0644]
t/chainlint/if-in-loop.expect [new file with mode: 0644]
t/chainlint/if-in-loop.test [new file with mode: 0644]
t/chainlint/loop-in-if.expect [new file with mode: 0644]
t/chainlint/loop-in-if.test [new file with mode: 0644]