| commit | 0a268826214ae8e50ba504f44067899976f48716 | |
| author | Christian Couder <christian.couder@gmail.com> | |
| Sun, 5 Nov 2017 21:38:29 +0000 (5 22:38 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 7 Nov 2017 00:54:41 +0000 (7 09:54 +0900) | ||
| tree | 6f83c327007224d4b1a0384dcaa7844f8cfab057 | treesnapshot (tar.gz zip) |
| parent | 4843cdefe3f30d19c1b2cf601522152c1413459a | commitdiff |
t0021/rot13-filter: fix list comparison
Since edcc8581 ("convert: add filter.<driver>.process
option", 2016-10-16) when t0021/rot13-filter.pl was created, list
comparison in this perl script have been quite broken.
packet_txt_read() returns a 2-element list, and the right hand
side of "eq" also has a list with (two, elements), but "eq" takes
the last element of the list on each side, and compares them. The
first elements (0 or 1) on the right hand side lists do not matter,
which means we do not require to see a flush at the end of the
version -- a simple empty string or an EOF would do, which is
definitely not what we want.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Since edcc8581 ("convert: add filter.<driver>.process
option", 2016-10-16) when t0021/rot13-filter.pl was created, list
comparison in this perl script have been quite broken.
packet_txt_read() returns a 2-element list, and the right hand
side of "eq" also has a list with (two, elements), but "eq" takes
the last element of the list on each side, and compares them. The
first elements (0 or 1) on the right hand side lists do not matter,
which means we do not require to see a flush at the end of the
version -- a simple empty string or an EOF would do, which is
definitely not what we want.
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| t/t0021/rot13-filter.pl | diffblobblamehistory |