| commit | f581de1b7b9d17c83b188bf8ffe536fb8a9dd2a4 | |
| author | Stephen Boyd <bebarino@gmail.com> | |
| Tue, 30 Jun 2009 05:08:38 +0000 (29 22:08 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 6 Jul 2009 16:45:00 +0000 (6 09:45 -0700) | ||
| tree | a11dae2c4e5ee93216ef9d127f0af217728d2e92 | treesnapshot (tar.gz zip) |
| parent | dd787c19c4f011cc3adb422ef856f2c58d989640 | commitdiff |
completion: __git_config_get_set_variables() handle values with spaces
Commit 0065236 (bash completion: complete variable names for "git
config" with options 2009-05-08) implemented its config variable search
wrong. When a config contains a value with a space and a period (.) in
it, completion erroneously thinks that line in the configuration is
multiple config variables.
For example
$ cat .git/config
format.cc = Junio C Hamano <gitster@pobox.com>
$ git config --unset <TAB>
format.cc
<gitster@pobox.com>
Instead of using a for loop splitting across spaces, pipe each line to a
while read loop and beef up the case statement to match only
'config.variable=value'.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commit 0065236 (bash completion: complete variable names for "git
config" with options 2009-05-08) implemented its config variable search
wrong. When a config contains a value with a space and a period (.) in
it, completion erroneously thinks that line in the configuration is
multiple config variables.
For example
$ cat .git/config
format.cc = Junio C Hamano <gitster@pobox.com>
$ git config --unset <TAB>
format.cc
<gitster@pobox.com>
Instead of using a for loop splitting across spaces, pipe each line to a
while read loop and beef up the case statement to match only
'config.variable=value'.
Signed-off-by: Stephen Boyd <bebarino@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| contrib/completion/git-completion.bash | diffblobblamehistory |