| commit | df17e77c0aacca35eaaac885fe70d97654c07d62 | |
| author | Johannes Sixt <j6t@kdbg.org> | |
| Wed, 4 Sep 2013 07:24:47 +0000 (4 09:24 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 4 Sep 2013 17:35:25 +0000 (4 10:35 -0700) | ||
| tree | 111bb8c6f1cdf0645ade368faf0b2c6c86ceda06 | treesnapshot (tar.gz zip) |
| parent | e230c568c4b9a991e3175e5f65171a566fd8e39c | commitdiff |
add--interactive: fix external command invocation on Windows
Back in 21e9757e (Hack git-add--interactive to make it work with
ActiveState Perl, 2007-08-01), the invocation of external commands was
changed to use qx{} on Windows. The rationale was that the command
interpreter on Windows is not a POSIX shell, but rather Windows's CMD.
That patch was wrong to include 'msys' in the check whether to use qx{}
or not: 'msys' identifies MSYS perl as shipped with Git for Windows,
which does not need the special treatment; qx{} should be used only with
ActiveState perl, which is identified by 'MSWin32'.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Back in 21e9757e (Hack git-add--interactive to make it work with
ActiveState Perl, 2007-08-01), the invocation of external commands was
changed to use qx{} on Windows. The rationale was that the command
interpreter on Windows is not a POSIX shell, but rather Windows's CMD.
That patch was wrong to include 'msys' in the check whether to use qx{}
or not: 'msys' identifies MSYS perl as shipped with Git for Windows,
which does not need the special treatment; qx{} should be used only with
ActiveState perl, which is identified by 'MSWin32'.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-add--interactive.perl | diffblobblamehistory |