| commit | c5eadcaab1d3969a4fbc009c65be622271edddd9 | |
| author | Jeff King <peff@peff.net> | |
| Mon, 23 Mar 2015 03:54:00 +0000 (22 23:54 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 23 Mar 2015 04:39:18 +0000 (22 21:39 -0700) | ||
| tree | da73e2b968aa40ee781cce63acc5290c573437a2 | treesnapshot (tar.gz zip) |
| parent | 1d4974c9bcbe3c9c0611cb056730d49c6b0b6b5e | commitdiff |
trailer: use capture_command
When we read from a trailer.*.command sub-program, the
current code uses run_command followed by a pipe read, which
can result in deadlock (though in practice you would have to
have a large trailer for this to be a problem). The current
code also leaks the file descriptor for the pipe to the
sub-command.
Instead, let's use capture_command, which makes this simpler
(and we can get rid of our custom helper).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When we read from a trailer.*.command sub-program, the
current code uses run_command followed by a pipe read, which
can result in deadlock (though in practice you would have to
have a large trailer for this to be a problem). The current
code also leaks the file descriptor for the pipe to the
sub-command.
Instead, let's use capture_command, which makes this simpler
(and we can get rid of our custom helper).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| trailer.c | diffblobblamehistory |