| commit | 3e333036ccbb97fddf54bd8fe74b12ba46f1687b | |
| author | Thomas Rast <trast@student.ethz.ch> | |
| Fri, 11 Jun 2010 15:02:50 +0000 (11 17:02 +0200) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 11 Jun 2010 20:46:25 +0000 (11 13:46 -0700) | ||
| tree | b3eeb160e80f92bec50e15b7c3d7e15cc612dbe9 | treesnapshot (tar.gz zip) |
| parent | f6b6098316192475ff0b3fa2ba894d7e555bdfac | commitdiff |
fast-import: die_nicely() back to vsnprintf (reverts part of ebaa79f)
ebaa79f (Make report() from usage.c public as vreportf() and use it.,
2010-03-06) changed fast-import's die_nicely() to use vreportf().
Unfortunately this is not possible: we need the message again for
write_report(), and vreportf() uses vsnprintf(), which invalidates the
va_list. As pointed out by Erik Faye-Lund, va_copy is C99 and thus
not an option.
So revert the part of ebaa79f that pertains to die_nicely().
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
ebaa79f (Make report() from usage.c public as vreportf() and use it.,
2010-03-06) changed fast-import's die_nicely() to use vreportf().
Unfortunately this is not possible: we need the message again for
write_report(), and vreportf() uses vsnprintf(), which invalidates the
va_list. As pointed out by Erik Faye-Lund, va_copy is C99 and thus
not an option.
So revert the part of ebaa79f that pertains to die_nicely().
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| fast-import.c | diffblobblamehistory |