| commit | 21134714787a02a37da15424d72c0119b2b8ed71 | |
| author | Jeff King <peff@peff.net> | |
| Fri, 17 Oct 2014 01:11:43 +0000 (16 21:11 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 19 Oct 2014 22:08:38 +0000 (19 15:08 -0700) | ||
| tree | ae02ffed1ca43594b4dcc4a66ddff7f3f24146f3 | treesnapshot (tar.gz zip) |
| parent | 76f8611a5fb7e81c1bada0fb190d573a66fc03f6 | commitdiff |
pack-objects: turn off bitmaps when we split packs
If a pack.packSizeLimit is set, we may split the pack data
across multiple packfiles. This means we cannot generate
.bitmap files, as they require that all of the reachable
objects are in the same pack. We check that condition when
we are generating the list of objects to pack (and disable
bitmaps if we are not packing everything), but we forgot to
update it when we notice that we needed to split (which
doesn't happen until the actual write phase).
The resulting bitmaps are quite bogus (they mention entries
that do not exist in the pack!) and can cause a fetch or
push to send insufficient objects.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
If a pack.packSizeLimit is set, we may split the pack data
across multiple packfiles. This means we cannot generate
.bitmap files, as they require that all of the reachable
objects are in the same pack. We check that condition when
we are generating the list of objects to pack (and disable
bitmaps if we are not packing everything), but we forgot to
update it when we notice that we needed to split (which
doesn't happen until the actual write phase).
The resulting bitmaps are quite bogus (they mention entries
that do not exist in the pack!) and can cause a fetch or
push to send insufficient objects.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/pack-objects.c | diffblobblamehistory | |
| t/t5310-pack-bitmaps.sh | diffblobblamehistory |