| commit | 0da43a685aa061f55ed19ea30e1d6220020059a6 | |
| author | Jay Soffian <jaysoffian@gmail.com> | |
| Sun, 5 Apr 2009 03:23:21 +0000 (4 23:23 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sun, 5 Apr 2009 05:53:32 +0000 (4 22:53 -0700) | ||
| tree | a68c647131877ba36e148724fa160c190cfdac7c | treesnapshot (tar.gz zip) |
| parent | e96f3689ecd95997a2a474c2b7f21b0a67f138b1 | commitdiff |
send-email: fix nasty bug in ask() function
Commit 6e18251 (send-email: refactor and ensure prompting doesn't loop
forever) introduced an ask function, which unfortunately had a nasty
bug. This caused it not to accept anything but the default reply to the
"Who should the emails appear to be from?" prompt, and nothing but
ctrl-d to the "Who should the emails be sent to?" and "Message-ID to be
used as In-Reply-To for the first email?" prompts.
This commit corrects the issues and adds a test to confirm the fix.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commit 6e18251 (send-email: refactor and ensure prompting doesn't loop
forever) introduced an ask function, which unfortunately had a nasty
bug. This caused it not to accept anything but the default reply to the
"Who should the emails appear to be from?" prompt, and nothing but
ctrl-d to the "Who should the emails be sent to?" and "Message-ID to be
used as In-Reply-To for the first email?" prompts.
This commit corrects the issues and adds a test to confirm the fix.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-send-email.perl | diffblobblamehistory | |
| t/t9001-send-email.sh | diffblobblamehistory |