From 687296960d774a45df31df7bc371d01106a6f6b7 Mon Sep 17 00:00:00 2001 From: Brandon Casey Date: Fri, 7 Oct 2011 22:20:21 -0500 Subject: [PATCH] refs.c: abort ref search if ref array is empty The bsearch() implementation on IRIX 6.5 segfaults if it is passed NULL for the base array argument even if number-of-elements is zero. So, let's work around it by detecting an empty array and aborting early. This is a useful optimization in its own right anyway, since we avoid a useless allocation and initialization of the ref_entry when the ref array is empty. Signed-off-by: Brandon Casey Signed-off-by: Junio C Hamano --- refs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/refs.c b/refs.c index c31b461662..cbc4c5d28d 100644 --- a/refs.c +++ b/refs.c @@ -110,6 +110,9 @@ static struct ref_entry *search_ref_array(struct ref_array *array, const char *n if (name == NULL) return NULL; + if (!array->nr) + return NULL; + len = strlen(name) + 1; e = xmalloc(sizeof(struct ref_entry) + len); memcpy(e->name, name, len); -- 2.11.4.GIT