From 2e82d0420dfe846fecc8f7b0f5bce684956d719e Mon Sep 17 00:00:00 2001 From: Johannes Sixt Date: Thu, 19 Dec 2013 08:10:59 +0100 Subject: [PATCH] gitk: Fix typo in proc blobdiffmaybeseehere The recent 5de460a2 (Refactor per-line part of getblobdiffline and its support) introduced blobdiffmaybeseehere, and accidentally forgot the '$' to access the parameter as a TCL variable. This resulted in a failing "Back" button with the error can't use non-numeric string as operand of "!" while executing "if {!$ateof} { set nlines [expr {[winfo height $ctext] / [font metrics textfont -linespace]}] if {[$ctext compare "$target_scrollpos + $nlines ..." (procedure "maybe_scroll_ctext" line 5) Signed-off-by: Johannes Sixt --- gitk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gitk b/gitk index 7bfefe2048..3f6fb9165f 100755 --- a/gitk +++ b/gitk @@ -7923,7 +7923,7 @@ proc blobdiffmaybeseehere {ateof} { if {$diffseehere >= 0} { mark_ctext_line [lindex [split $diffseehere .] 0] } - maybe_scroll_ctext ateof + maybe_scroll_ctext $ateof } proc getblobdiffline {bdf ids} { -- 2.11.4.GIT