| commit | cac05d4dfd148071462939a61ecd44cf932a0b02 | |
| author | Jeff King <peff@peff.net> | |
| Wed, 15 Oct 2014 22:40:58 +0000 (15 18:40 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 16 Oct 2014 17:10:41 +0000 (16 10:10 -0700) | ||
| tree | 278f7256254da08af94c6339803771c749abb278 | treesnapshot (tar.gz zip) |
| parent | 0d3b729680e9cab0f567122e796dab2bc9bc8cfb | commitdiff |
count-objects: do not use xsize_t when counting object size
The point of xsize_t is to safely cast an off_t into a size_t
(because we are about to mmap). But in count-objects, we are
summing the sizes in an off_t. Using xsize_t means that
count-objects could fail on a 32-bit system with a 4G
object (not likely, as other parts of git would fail, but
we should at least be correct here).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The point of xsize_t is to safely cast an off_t into a size_t
(because we are about to mmap). But in count-objects, we are
summing the sizes in an off_t. Using xsize_t means that
count-objects could fail on a 32-bit system with a 4G
object (not likely, as other parts of git would fail, but
we should at least be correct here).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/count-objects.c | diffblobblamehistory |