| commit | b575b2f1f420bf82557beab0f4ec12e5aa832bea | |
| author | Pat Thoyts <patthoyts@users.sourceforge.net> | |
| Wed, 15 Apr 2009 15:54:19 +0000 (15 16:54 +0100) | ||
| committer | Paul Mackerras <paulus@samba.org> | |
| Fri, 17 Apr 2009 12:47:49 +0000 (17 22:47 +1000) | ||
| tree | 5e33ed089d319002203448e0a1e7a33c39b9b104 | treesnapshot (tar.gz zip) |
| parent | c876dbadc2d44386962296f09a060c3ae69e2029 | commitdiff |
gitk: Handle external diff tool with spaces in the path
This fixes the launching of external diff to handle a diff tool
that has spaces in the path. This ensures a correctly formed
tcl list is passed to the open command with a single pipe character
prefixing the list (as per the tcl manual page for open).
The specific fault observed was that selecting WinMerge as the diff
tool from the default installed location in Program Files failed to
be launched from the context menu.
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This fixes the launching of external diff to handle a diff tool
that has spaces in the path. This ensures a correctly formed
tcl list is passed to the open command with a single pipe character
prefixing the list (as per the tcl manual page for open).
The specific fault observed was that selecting WinMerge as the diff
tool from the default installed location in Program Files failed to
be launched from the context menu.
Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
| gitk | diffblobblamehistory |