| commit | 969eba6341a5af8ac52c67e26462548ed05e23e3 | |
| author | Jeff King <peff@peff.net> | |
| Tue, 10 Jun 2014 21:39:04 +0000 (10 17:39 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 12 Jun 2014 17:29:42 +0000 (12 10:29 -0700) | ||
| tree | 5ad116ce4e50cd2396c16d6de4f17cdb4cd30e80 | treesnapshot (tar.gz zip) |
| parent | c335d74d349d201cb7627aa7233638d2953a4b02 | commitdiff |
commit: push commit_index update into alloc_commit_node
Whenever we create a commit object via lookup_commit, we
give it a unique index to be used with the commit-slab API.
The theory is that any "struct commit" we create would
follow this code path, so any such struct would get an
index. However, callers could use alloc_commit_node()
directly (and get multiple commits with index 0).
Let's push the indexing into alloc_commit_node so that it's
hard for callers to get it wrong.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Whenever we create a commit object via lookup_commit, we
give it a unique index to be used with the commit-slab API.
The theory is that any "struct commit" we create would
follow this code path, so any such struct would get an
index. However, callers could use alloc_commit_node()
directly (and get multiple commits with index 0).
Let's push the indexing into alloc_commit_node so that it's
hard for callers to get it wrong.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| alloc.c | diffblobblamehistory | |
| commit.c | diffblobblamehistory |