| commit | 340814636dde3cbd2e461b12f9ae832d2100766a | |
| author | Nicolas Pitre <nico@cam.org> | |
| Thu, 28 Feb 2008 05:25:18 +0000 (28 00:25 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sat, 1 Mar 2008 09:44:45 +0000 (1 01:44 -0800) | ||
| tree | dfe72ebd2496deec0797aa1e685a7f8d78468122 | treesnapshot (tar.gz zip) |
| parent | 3449f8c4cb93a0ec445db22ee7549d0b051446d6 | commitdiff |
make verify_one_pack() a bit less wrong wrt packed_git structure
Simply freeing it is wrong. There are many things attached to this
structure that are not cleaned up. In practice this doesn't matter much
since this happens just before the program exits, but it is still
a bit more "correct" to leak it implicitly rather than explicitly.
And therefore it is also a good idea to register it with
install_packed_git(). Not only might it have better chance of being
properly cleaned up if such functionality is implemented for the general
case, but some functions like init_revindex() expect all packed_git
instances to be globally accessible.
Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Simply freeing it is wrong. There are many things attached to this
structure that are not cleaned up. In practice this doesn't matter much
since this happens just before the program exits, but it is still
a bit more "correct" to leak it implicitly rather than explicitly.
And therefore it is also a good idea to register it with
install_packed_git(). Not only might it have better chance of being
properly cleaned up if such functionality is implemented for the general
case, but some functions like init_revindex() expect all packed_git
instances to be globally accessible.
Signed-off-by: Nicolas Pitre <nico@cam.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin-verify-pack.c | diffblobblamehistory |