| commit | fa5d5a30aefd96e7c83bb2cdb8d49549400d6ae6 | |
| author | Adam Roben <adam@roben.org> | |
| Tue, 5 Jun 2012 14:24:11 +0000 (5 10:24 -0400) | ||
| committer | Stepan Kasal <kasal@ucw.cz> | |
| Thu, 15 May 2014 07:43:09 +0000 (15 09:43 +0200) | ||
| tree | 8fec393b8145c39ffc3e7b094f0fd24a15c9221f | treesnapshot (tar.gz zip) |
| parent | 6dd942bc03ee7c06396dad4d7ed6eb265c487224 | commitdiff |
Fix launching of externals from Unicode paths
If Git were installed in a path containing non-ASCII characters,
commands such as git-am and git-submodule, which are implemented as
externals, would fail to launch with the following error:
> fatal: 'am' appears to be a git command, but we were not
> able to execute it. Maybe git-am is broken?
This was due to lookup_prog not being Unicode-aware. It was somehow
missed in 2ee5a1a14ad17ff35f0ad52390a27fbbc41258f3.
Note that the only problem in this function was calling
GetFileAttributes instead of GetFileAttributesW. The calls to access()
were fine because access() is a macro which resolves to mingw_access,
which already handles Unicode correctly. But I changed lookup_prog to
use _waccess directly so that we only convert the path to UTF-16 once.
Signed-off-by: Adam Roben <adam@roben.org>
If Git were installed in a path containing non-ASCII characters,
commands such as git-am and git-submodule, which are implemented as
externals, would fail to launch with the following error:
> fatal: 'am' appears to be a git command, but we were not
> able to execute it. Maybe git-am is broken?
This was due to lookup_prog not being Unicode-aware. It was somehow
missed in 2ee5a1a14ad17ff35f0ad52390a27fbbc41258f3.
Note that the only problem in this function was calling
GetFileAttributes instead of GetFileAttributesW. The calls to access()
were fine because access() is a macro which resolves to mingw_access,
which already handles Unicode correctly. But I changed lookup_prog to
use _waccess directly so that we only convert the path to UTF-16 once.
Signed-off-by: Adam Roben <adam@roben.org>
| compat/mingw.c | diffblobblamehistory |