| commit | 609d83243df1fbd15eb55b98c46987b09b2a9b31 | |
| author | Karsten Blees <blees@dcon.de> | |
| Thu, 15 Mar 2012 19:37:26 +0000 (15 20:37 +0100) | ||
| committer | Johannes Schindelin <johannes.schindelin@gmx.de> | |
| Fri, 27 Dec 2013 16:04:56 +0000 (27 10:04 -0600) | ||
| tree | 968e838248a27e433ee7b7fb83307f19bdc76ec4 | treesnapshot (tar.gz zip) |
| parent | 87b4e463818a90c67af75dbdd3983fef74d88635 | commitdiff |
Win32: fix detection of empty directories in is_dir_empty
On Windows XP (not Win7), directories cannot be deleted while a find handle
is open, causing "Deletion of directory '...' failed. Should I try again?"
prompts.
Prior to 19d1e75d "Win32: Unicode file name support (except dirent)",
these failures were silently ignored due to strbuf_free in is_dir_empty
resetting GetLastError to ERROR_SUCCESS.
Close the find handle in is_dir_empty so that git doesn't block deletion
of the directory even after all other applications have released it.
Reported-by: John Chen <john0312@gmail.com>
Signed-off-by: Karsten Blees <blees@dcon.de>
On Windows XP (not Win7), directories cannot be deleted while a find handle
is open, causing "Deletion of directory '...' failed. Should I try again?"
prompts.
Prior to 19d1e75d "Win32: Unicode file name support (except dirent)",
these failures were silently ignored due to strbuf_free in is_dir_empty
resetting GetLastError to ERROR_SUCCESS.
Close the find handle in is_dir_empty so that git doesn't block deletion
of the directory even after all other applications have released it.
Reported-by: John Chen <john0312@gmail.com>
Signed-off-by: Karsten Blees <blees@dcon.de>
| compat/mingw.c | diffblobblamehistory |