| commit | 5d88db7b013afc7e38330496d34dcf473a5c364e | |
| author | Adam Roben <adam@roben.org> | |
| Tue, 5 Jun 2012 14:24:11 +0000 (5 10:24 -0400) | ||
| committer | Johannes Schindelin <johannes.schindelin@gmx.de> | |
| Mon, 17 Feb 2014 18:08:13 +0000 (17 12:08 -0600) | ||
| tree | 9504b9e8efa7bae566066b1b99bfecbd046d656a | treesnapshot (tar.gz zip) |
| parent | 5cc7c27b4fc15bfae0122e4927359a438e6828b8 | commitdiff |
Fix launching of externals from Unicode paths
If Git were installed in a path containing non-ASCII characters,
commands such as git-am and git-submodule, which are implemented as
externals, would fail to launch with the following error:
> fatal: 'am' appears to be a git command, but we were not
> able to execute it. Maybe git-am is broken?
This was due to lookup_prog not being Unicode-aware. It was somehow
missed in 2ee5a1a14ad17ff35f0ad52390a27fbbc41258f3.
Note that the only problem in this function was calling
GetFileAttributes instead of GetFileAttributesW. The calls to access()
were fine because access() is a macro which resolves to mingw_access,
which already handles Unicode correctly. But I changed lookup_prog to
use _waccess directly so that we only convert the path to UTF-16 once.
Signed-off-by: Adam Roben <adam@roben.org>
If Git were installed in a path containing non-ASCII characters,
commands such as git-am and git-submodule, which are implemented as
externals, would fail to launch with the following error:
> fatal: 'am' appears to be a git command, but we were not
> able to execute it. Maybe git-am is broken?
This was due to lookup_prog not being Unicode-aware. It was somehow
missed in 2ee5a1a14ad17ff35f0ad52390a27fbbc41258f3.
Note that the only problem in this function was calling
GetFileAttributes instead of GetFileAttributesW. The calls to access()
were fine because access() is a macro which resolves to mingw_access,
which already handles Unicode correctly. But I changed lookup_prog to
use _waccess directly so that we only convert the path to UTF-16 once.
Signed-off-by: Adam Roben <adam@roben.org>
| compat/mingw.c | diffblobblamehistory |