| commit | 447b99c8b1102746054644acd268f4c1b115a9f8 | |
| author | Jeff King <peff@peff.net> | |
| Mon, 23 Jul 2012 18:48:57 +0000 (23 14:48 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 23 Jul 2012 20:10:43 +0000 (23 13:10 -0700) | ||
| tree | 8a8eedaa50f8ccaf477d0341648dd0b8465a6bb1 | treesnapshot (tar.gz zip) |
| parent | d0f1ea6003d97e63110fa7d50bb07f546a909b6e | commitdiff |
advice: pass varargs to strbuf_vaddf, not strbuf_addf
The advise() function takes a variable number of arguments
and converts them into a va_list object to pass to strbuf
for handling. However, we accidentally called strbuf_addf
(that takes a variable number of arguments) instead of
strbuf_vaddf (that takes a va_list).
This bug dates back to v1.7.8.1-1-g23cb5bf, but we never
noticed because none of the current callers passes a string
with a format specifier in it. And the compiler did not
notice because the format string is not available at
compile time.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The advise() function takes a variable number of arguments
and converts them into a va_list object to pass to strbuf
for handling. However, we accidentally called strbuf_addf
(that takes a variable number of arguments) instead of
strbuf_vaddf (that takes a va_list).
This bug dates back to v1.7.8.1-1-g23cb5bf, but we never
noticed because none of the current callers passes a string
with a format specifier in it. And the compiler did not
notice because the format string is not available at
compile time.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| advice.c | diffblobblamehistory |