| commit | 1c3ebb385ec6cfd661e6d8e331f23a282da6a976 | |
| author | Karsten Blees <blees@dcon.de> | |
| Thu, 15 Mar 2012 19:37:26 +0000 (15 20:37 +0100) | ||
| committer | Pat Thoyts <patthoyts@users.sourceforge.net> | |
| Thu, 31 Jan 2013 23:46:34 +0000 (31 23:46 +0000) | ||
| tree | 61aab709455ea3ea287de253f04c95c1e7fa0d27 | treesnapshot (tar.gz zip) |
| parent | 000ab3834a9c628be82024ab584e410b063e7447 | commitdiff |
Win32: fix detection of empty directories in is_dir_empty
On Windows XP (not Win7), directories cannot be deleted while a find handle
is open, causing "Deletion of directory '...' failed. Should I try again?"
prompts.
Prior to 19d1e75d "Win32: Unicode file name support (except dirent)",
these failures were silently ignored due to strbuf_free in is_dir_empty
resetting GetLastError to ERROR_SUCCESS.
Close the find handle in is_dir_empty so that git doesn't block deletion
of the directory even after all other applications have released it.
Reported-by: John Chen <john0312@gmail.com>
Signed-off-by: Karsten Blees <blees@dcon.de>
On Windows XP (not Win7), directories cannot be deleted while a find handle
is open, causing "Deletion of directory '...' failed. Should I try again?"
prompts.
Prior to 19d1e75d "Win32: Unicode file name support (except dirent)",
these failures were silently ignored due to strbuf_free in is_dir_empty
resetting GetLastError to ERROR_SUCCESS.
Close the find handle in is_dir_empty so that git doesn't block deletion
of the directory even after all other applications have released it.
Reported-by: John Chen <john0312@gmail.com>
Signed-off-by: Karsten Blees <blees@dcon.de>
| compat/mingw.c | diffblobblamehistory |