From bf142ec4346385553918bc53f203b205091aa362 Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Wed, 17 Jul 2013 15:27:19 -0700 Subject: [PATCH] diff: reject unknown change class given to --diff-filter We used to accept "git diff --diff-filter=Q" (note that there is no such change class 'Q') silently and showed no output (because there is no such change class 'Q'). Error out when such an input is given. Signed-off-by: Junio C Hamano --- diff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/diff.c b/diff.c index 03f10e6516..3d37b56778 100644 --- a/diff.c +++ b/diff.c @@ -3537,7 +3537,7 @@ static int parse_diff_filter_opt(const char *optarg, struct diff_options *opt) bit = (0 <= optch && optch <= 'Z') ? filter_bit[optch] : 0; if (!bit) - continue; /* ignore unknown ones, like we always have */ + return optarg[i]; opt->filter |= bit; } return 0; -- 2.11.4.GIT