receive-pack: crash when checking with non-exist HEAD
commitb112b14d7869bf3c000abb84cd22e57dd811d031
authorJiang Xin <worldhello.net@gmail.com>
Wed, 22 Jul 2015 01:49:40 +0000 (22 09:49 +0800)
committerJunio C Hamano <gitster@pobox.com>
Wed, 22 Jul 2015 21:18:22 +0000 (22 14:18 -0700)
tree8ae07a38f729524bad1bbb4a932e4fa37a50a2dc
parent282616c72d1d08a77ca4fe1186cb708c38408d87
receive-pack: crash when checking with non-exist HEAD

If HEAD of a repository points to a conflict reference, such as:

* There exist a reference named 'refs/heads/jx/feature1', but HEAD
  points to 'refs/heads/jx', or

* There exist a reference named 'refs/heads/feature', but HEAD points
  to 'refs/heads/feature/bad'.

When we push to delete a reference for this repo, such as:

        git push /path/to/bad-head-repo.git :some/good/reference

The git-receive-pack process will crash.

This is because if HEAD points to a conflict reference, the function
`resolve_refdup("HEAD", ...)` does not return a valid reference name,
but a null buffer.  Later matching the delete reference against the null
buffer will cause git-receive-pack crash.

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/receive-pack.c