sha1-lookup: handle duplicates in sha1_pos()
commit0eb0fb889e2e7e063e7dd8cbee38af106aa195f6
authorRené Scharfe <l.s.r@web.de>
Wed, 1 Oct 2014 15:02:37 +0000 (1 17:02 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 1 Oct 2014 20:32:19 +0000 (1 13:32 -0700)
treee58599db7b1f213bed7556af99176d1fbc089cbb
parent38d905bf585999367a24fa27645ece6fe996d6f0
sha1-lookup: handle duplicates in sha1_pos()

If the first 18 bytes of the SHA1's of all entries are the same then
sha1_pos() dies and reports that the lower and upper limits of the
binary search were the same that this wasn't supposed to happen.  This
is wrong because the remaining two bytes could still differ.

Furthermore: It wouldn't be a problem if they actually were the same,
i.e. if all entries have the same SHA1.  The code already handles
duplicates just fine.  Simply remove the erroneous check.

Signed-off-by: Rene Scharfe <l.s.r@web.de>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sha1-lookup.c
t/t0064-sha1-array.sh