| commit | 0539cc0038ff3411da1fea342b7d6615643bff5b | |
| author | Jeff King <peff@peff.net> | |
| Wed, 18 Jun 2014 19:51:17 +0000 (18 15:51 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 20 Jun 2014 17:45:19 +0000 (20 10:45 -0700) | ||
| tree | d8be8b442d56b28de63051611c99821f2a58eab2 | treesnapshot (tar.gz zip) |
| parent | d12c24d2a96f8f9aeb100b800d8fb217f28a6a2a | commitdiff |
stat_opt: check extra strlen call
As in earlier commits, the diff option parser uses
starts_with to find that an argument starts with "--stat-",
and then adds strlen("stat-") to find the rest of the
option.
However, in this case the starts_with and the strlen are
separated across functions, making it easy to call the
latter without the former. Let's use skip_prefix instead of
raw pointer arithmetic to catch such a case.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
As in earlier commits, the diff option parser uses
starts_with to find that an argument starts with "--stat-",
and then adds strlen("stat-") to find the rest of the
option.
However, in this case the starts_with and the strlen are
separated across functions, making it easy to call the
latter without the former. Let's use skip_prefix instead of
raw pointer arithmetic to catch such a case.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| diff.c | diffblobblamehistory |