From f755bb996ba0540d668104d0e2d4e03bb71b560b Mon Sep 17 00:00:00 2001 From: Alex Riesen Date: Wed, 19 Nov 2008 12:14:05 +0100 Subject: [PATCH] Fix handle leak in sha1_file/unpack_objects if there were damaged object data In the case of bad packed object CRC, unuse_pack wasn't called after check_pack_crc which calls use_pack. Signed-off-by: Alex Riesen Acked-by: Nicolas Pitre Signed-off-by: Junio C Hamano --- sha1_file.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sha1_file.c b/sha1_file.c index 75a748a644..0106e2ce5c 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -1749,6 +1749,7 @@ void *unpack_entry(struct packed_git *p, off_t obj_offset, error("bad packed object CRC for %s", sha1_to_hex(sha1)); mark_bad_packed_object(p, sha1); + unuse_pack(&w_curs); return NULL; } } -- 2.11.4.GIT