| commit | b2724c87872aaec55dd7e5529aa029c3108b43a5 | |
| author | Jeff King <peff@peff.net> | |
| Thu, 19 Jun 2014 21:26:56 +0000 (19 17:26 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 19 Jun 2014 22:20:54 +0000 (19 15:20 -0700) | ||
| tree | 905e0c855f087699b8a5fd8054271a8e7c5d9dad | treesnapshot (tar.gz zip) |
| parent | 283101869bea8feb5d58f6ea1b568e9b197526d3 | commitdiff |
use xstrfmt to replace xmalloc + strcpy/strcat
It's easy to get manual allocation calculations wrong, and
the use of strcpy/strcat raise red flags for people looking
for buffer overflows (though in this case each site was
fine).
It's also shorter to use xstrfmt, and the printf-format
tends to be easier for a reader to see what the final string
will look like.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
It's easy to get manual allocation calculations wrong, and
the use of strcpy/strcat raise red flags for people looking
for buffer overflows (though in this case each site was
fine).
It's also shorter to use xstrfmt, and the printf-format
tends to be easier for a reader to see what the final string
will look like.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/apply.c | diffblobblamehistory | |
| builtin/fetch.c | diffblobblamehistory | |
| builtin/name-rev.c | diffblobblamehistory | |
| sha1_name.c | diffblobblamehistory | |
| shell.c | diffblobblamehistory |