| commit | 53e1a761be8d338cd957870bc1e48a8c15d7d2c0 | |
| author | Junio C Hamano <junkio@cox.net> | |
| Tue, 15 Aug 2006 23:28:08 +0000 (15 16:28 -0700) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Wed, 16 Aug 2006 04:02:16 +0000 (15 21:02 -0700) | ||
| tree | eebe330e39ee4882629f92e04feeceaf89e26e45 | treesnapshot (tar.gz zip) |
| parent | 1d6249e609289940dca179b626fe4ae5433c90cc | commitdiff |
finish_connect(): thinkofix
All but one callers have ignore the return value from this
function, but the only caller, builtin-tar-tree.c::remote_tar(),
assumed it returns non-zero on failure and zero on success. The
implementation however was returning either the waited pid
(which must be the same as its input) or -1 (an error).
Fix this thinko, while getting rid of an assignment of return
value from waitpid() into a variable of type int.
Signed-off-by: Junio C Hamano <junkio@cox.net>
All but one callers have ignore the return value from this
function, but the only caller, builtin-tar-tree.c::remote_tar(),
assumed it returns non-zero on failure and zero on success. The
implementation however was returning either the waited pid
(which must be the same as its input) or -1 (an error).
Fix this thinko, while getting rid of an assignment of return
value from waitpid() into a variable of type int.
Signed-off-by: Junio C Hamano <junkio@cox.net>
| connect.c | diffblobblamehistory |