| commit | 4764f46492b0849ce3cf2f527978acd9c2d5f7e6 | |
| author | Jon Seymour <jon.seymour@gmail.com> | |
| Thu, 4 Aug 2011 12:00:57 +0000 (4 22:00 +1000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 4 Aug 2011 22:32:34 +0000 (4 15:32 -0700) | ||
| tree | d743dff39c936708497e0a510b3531835edecac4 | treesnapshot (tar.gz zip) |
| parent | b35acb53458d0f99ba2400b902980b35e5acc2d3 | commitdiff |
bisect: move argument parsing before state modification.
Currently 'git bisect start' modifies some state prior to checking
that its arguments are valid.
This change moves argument validation before state modification
with the effect that state modification does not occur
unless argument validations succeeds.
An existing test is changed to check that new bisect state
is not created if arguments are invalid.
A new test is added to check that existing bisect state
is not modified if arguments are invalid.
Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Currently 'git bisect start' modifies some state prior to checking
that its arguments are valid.
This change moves argument validation before state modification
with the effect that state modification does not occur
unless argument validations succeeds.
An existing test is changed to check that new bisect state
is not created if arguments are invalid.
A new test is added to check that existing bisect state
is not modified if arguments are invalid.
Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-bisect.sh | diffblobblamehistory | |
| t/t6030-bisect-porcelain.sh | diffblobblamehistory |