From 95b104c830caa74a5702bcabc3bbb920b0eba07d Mon Sep 17 00:00:00 2001 From: Johannes Sixt Date: Tue, 11 Jan 2011 08:44:30 +0100 Subject: [PATCH] t/README: hint about using $(pwd) rather than $PWD in tests This adds just a "do it this way" instruction without a lot of explanation, because the details are too complex to be explained at this point. Signed-off-by: Johannes Sixt Signed-off-by: Junio C Hamano --- t/README | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/t/README b/t/README index 892d443f63..25f7d2d2e3 100644 --- a/t/README +++ b/t/README @@ -283,6 +283,12 @@ Do: Tests that are likely to smoke out future regressions are better than tests that just inflate the coverage metrics. + - When a test checks for an absolute path that a git command generated, + construct the expected value using $(pwd) rather than $PWD, + $TEST_DIRECTORY, or $TRASH_DIRECTORY. It makes a difference on + Windows, where the shell (MSYS bash) mangles absolute path names. + For details, see the commit message of 4114156ae9. + Don't: - exit() within a