From 74d817cf8cf68104564cf6c93c1361f66dad1901 Mon Sep 17 00:00:00 2001 From: Jochen Voss Date: Sat, 28 Jun 2008 17:04:24 +0100 Subject: [PATCH] avoid off-by-one error in run_upload_archive Make sure that buf has enough space to store the trailing \0 of the command line argument, too. Signed-off-by: Jochen Voss Signed-off-by: Junio C Hamano --- builtin-upload-archive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin-upload-archive.c b/builtin-upload-archive.c index 48ae09e9b5..371400d49a 100644 --- a/builtin-upload-archive.c +++ b/builtin-upload-archive.c @@ -30,7 +30,7 @@ static int run_upload_archive(int argc, const char **argv, const char *prefix) if (argc != 2) usage(upload_archive_usage); - if (strlen(argv[1]) > sizeof(buf)) + if (strlen(argv[1]) + 1 > sizeof(buf)) die("insanely long repository name"); strcpy(buf, argv[1]); /* enter-repo smudges its argument */ -- 2.11.4.GIT