| commit | 88ff684dd54f2a4793387f7162357005a4777ff2 | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Fri, 5 Apr 2013 04:03:21 +0000 (4 21:03 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Fri, 5 Apr 2013 17:31:09 +0000 (5 10:31 -0700) | ||
| tree | 728a60ee2993e595a897bc2a46be3a00928875a7 | treesnapshot (tar.gz zip) |
| parent | ebb722625805a0e98b5b8c062b79abd8eca1f639 | commitdiff |
diffcore-pickaxe: fix leaks in "log -S<block>" and "log -G<pattern>"
The diff_grep() and has_changes() functions had early return
codepaths for unmerged filepairs, which simply returned 0. When we
taught textconv filter to them, one was ignored and continued to
return early without freeing the result filtered by textconv, and
the other had a failed attempt to fix, which allowed the planned
return value 0 to be overwritten by a bogus call to contains().
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The diff_grep() and has_changes() functions had early return
codepaths for unmerged filepairs, which simply returned 0. When we
taught textconv filter to them, one was ignored and continued to
return early without freeing the result filtered by textconv, and
the other had a failed attempt to fix, which allowed the planned
return value 0 to be overwritten by a bogus call to contains().
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| diffcore-pickaxe.c | diffblobblamehistory |