| commit | 6319a2a148adaa78f11414e914f8c9f3f1c52b5e | |
| author | Jeff King <peff@peff.net> | |
| Wed, 18 Jul 2012 12:04:30 +0000 (18 08:04 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 18 Jul 2012 20:26:53 +0000 (18 13:26 -0700) | ||
| tree | a223fb037abb7b810227eb5efd70550a0f06765a | treesnapshot (tar.gz zip) |
| parent | 3e5f29e8963a9a6f1774add194ec19583c19fbb6 | commitdiff |
mw-to-git: check blank credential attributes via length
When writing a credential to git-credential, we omit fields
that do not have a true value. This will skip empty or
undefined fields (which we want), but will also accidentally
skip usernames or passwords which happen to have a non-true
value (e.g., "0"). Be more careful by checking for non-zero
length.
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
When writing a credential to git-credential, we omit fields
that do not have a true value. This will skip empty or
undefined fields (which we want), but will also accidentally
skip usernames or passwords which happen to have a non-true
value (e.g., "0"). Be more careful by checking for non-zero
length.
Signed-off-by: Jeff King <peff@peff.net>
Acked-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| contrib/mw-to-git/git-remote-mediawiki | diffblobblamehistory |