| commit | 41ae8f1d6cf70f32328c984cdbe51d0f156cd501 | |
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | |
| Thu, 30 Sep 2010 13:43:09 +0000 (30 13:43 +0000) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Thu, 30 Sep 2010 19:20:33 +0000 (30 12:20 -0700) | ||
| tree | f97db962830780cbd84bab82d54144d5dc7e5c64 | treesnapshot (tar.gz zip) |
| parent | 529dd386dda6c6e6d0dad801785d2d943756fb3f | commitdiff |
send-email: use Perl idioms in while loop
Change `while(<$fh>) { my $c = $_' to `while(my $c = <$fh>) {', and
use `chomp $c' instead of `$c =~ s/\n$//g;', the two are equivalent in
this case.
I've also changed the --cccmd test so that we test for the stripping
of whitespace at the beginning of the lines returned from the
--cccmd. I think we probably shouldn't do this, but it was there
already so I haven't changed the behavior.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Change `while(<$fh>) { my $c = $_' to `while(my $c = <$fh>) {', and
use `chomp $c' instead of `$c =~ s/\n$//g;', the two are equivalent in
this case.
I've also changed the --cccmd test so that we test for the stripping
of whitespace at the beginning of the lines returned from the
--cccmd. I think we probably shouldn't do this, but it was there
already so I haven't changed the behavior.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com>
Reviewed-by: Jeff King <peff@peff.net>
>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-send-email.perl | diffblobblamehistory | |
| t/t9001-send-email.sh | diffblobblamehistory |