From bc4e7d035840539eb5aa13ab3d51ab43cc2c1b50 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 21 May 2007 09:58:01 +0200 Subject: [PATCH] git-daemon: don't ignore pid-file write failure Note: since the consequence of failure is to call die, I don't bother to close "f". Signed-off-by: Jim Meyering Signed-off-by: Junio C Hamano --- daemon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/daemon.c b/daemon.c index e74ecac952..674e30dca3 100644 --- a/daemon.c +++ b/daemon.c @@ -970,8 +970,8 @@ static void store_pid(const char *path) FILE *f = fopen(path, "w"); if (!f) die("cannot open pid file %s: %s", path, strerror(errno)); - fprintf(f, "%d\n", getpid()); - fclose(f); + if (fprintf(f, "%d\n", getpid()) < 0 || fclose(f) != 0) + die("failed to write pid file %s: %s", path, strerror(errno)); } static int serve(char *listen_addr, int listen_port, struct passwd *pass, gid_t gid) -- 2.11.4.GIT