From a7e1b15c5492c0d5da1187ed6d7a81270a1ec339 Mon Sep 17 00:00:00 2001 From: "brian m. carlson" Date: Sun, 22 Jan 2017 02:41:52 +0000 Subject: [PATCH] Documentation: remove unneeded argument in cat-texi.perl The newly-added use of the warnings pragma exposes that the $menu[0] argument to printf has long been silently ignored, since there is no format specifier for it. It doesn't appear that the argument is actually needed, either: there is no reason to insert the name of one particular documentation page anywhere in the header that's being generated. Remove the unused argument, and since the format specification functionality is no longer needed, convert the printf to a simple print. Signed-off-by: brian m. carlson Signed-off-by: Junio C Hamano --- Documentation/cat-texi.perl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/cat-texi.perl b/Documentation/cat-texi.perl index 1bc84d3c7c..14d2f83415 100755 --- a/Documentation/cat-texi.perl +++ b/Documentation/cat-texi.perl @@ -20,7 +20,7 @@ while () { } close $tmp; -printf '\input texinfo +print '\input texinfo @setfilename gitman.info @documentencoding UTF-8 @dircategory Development @@ -31,7 +31,7 @@ printf '\input texinfo @top Git Manual Pages @documentlanguage en @menu -', $menu[0]; +'; for (@menu) { print "* ${_}::\n"; -- 2.11.4.GIT