From 04408c3578300ac7cc1b1530bbaec54de299b200 Mon Sep 17 00:00:00 2001 From: Jakub Narebski Date: Sat, 18 Nov 2006 23:35:38 +0100 Subject: [PATCH] gitweb: Protect against possible warning in git_commitdiff We may read an undef from <$fd> and unconditionally chomping it would result in a warning. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano --- gitweb/gitweb.perl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 758759576c..b2482febfc 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3731,7 +3731,8 @@ sub git_commitdiff { $hash_parent, $hash, "--" or die_error(undef, "Open git-diff-tree failed"); - while (chomp(my $line = <$fd>)) { + while (my $line = <$fd>) { + chomp $line; # empty line ends raw part of diff-tree output last unless $line; push @difftree, $line; -- 2.11.4.GIT