| commit | e6e592db4c0099a6412aed6e868769535900f112 | |
| author | Jakub Narebski <jnareb@gmail.com> | |
| Sun, 14 Feb 2010 21:46:28 +0000 (14 22:46 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Mon, 15 Feb 2010 02:50:22 +0000 (14 18:50 -0800) | ||
| tree | 6b62d04f87f283507b684b36f8080f30ceddbe13 | treesnapshot (tar.gz zip) |
| parent | e923eaeb901ff056421b9007adcbbce271caa7b6 | commitdiff |
gitweb: Die if there are parsing errors in config file
Otherwise the errors can propagate, and show in damnest places, and
you would spend your time chasing ghosts instead of debugging real
problem (yes, it is from personal experience).
This follows (parts of) advice in `perldoc -f do` documentation.
This required restructoring code a bit, so we die only if we are reading
(executing) config file. As a side effect $GITWEB_CONFIG_SYSTEM is always
available, even when we use $GITWEB_CONFIG.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Otherwise the errors can propagate, and show in damnest places, and
you would spend your time chasing ghosts instead of debugging real
problem (yes, it is from personal experience).
This follows (parts of) advice in `perldoc -f do` documentation.
This required restructoring code a bit, so we die only if we are reading
(executing) config file. As a side effect $GITWEB_CONFIG_SYSTEM is always
available, even when we use $GITWEB_CONFIG.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| gitweb/gitweb.perl | diffblobblamehistory |