| commit | 46014766bdacec8ad22355ce78898b895bf172d6 | |
| author | Junio C Hamano <junkio@cox.net> | |
| Sat, 21 Oct 2006 07:41:38 +0000 (21 00:41 -0700) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Sat, 21 Oct 2006 07:41:38 +0000 (21 00:41 -0700) | ||
| tree | 47e714fdeb60a38f6b592e168a8a6bc3604c638d | treesnapshot (tar.gz zip) |
| parent | 612702e8ea3aa070586001f1aa0a2070058664e0 | commitdiff |
git-pickaxe: do not confuse two origins that are the same.
It used to be that we can compare the address of the origin
structure to determine if they are the same because they are
always registered with scoreboard. After introduction of the
loop to try finding the best split, that is not true anymore.
The current code has rather serious leaks with origin structure,
but more importantly it gets confused when two origins that
points at the same commit and same path.
We might eventually have to refcount and gc origin, but let's
fix the correctness issue first.
Signed-off-by: Junio C Hamano <junkio@cox.net>
It used to be that we can compare the address of the origin
structure to determine if they are the same because they are
always registered with scoreboard. After introduction of the
loop to try finding the best split, that is not true anymore.
The current code has rather serious leaks with origin structure,
but more importantly it gets confused when two origins that
points at the same commit and same path.
We might eventually have to refcount and gc origin, but let's
fix the correctness issue first.
Signed-off-by: Junio C Hamano <junkio@cox.net>
| builtin-pickaxe.c | diffblobblamehistory |