| commit | be510cfef3d8344007bd34128ca6eb799b714c8c | |
| author | Junio C Hamano <gitster@pobox.com> | |
| Tue, 18 Sep 2007 04:18:20 +0000 (17 21:18 -0700) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 18 Sep 2007 05:02:19 +0000 (17 22:02 -0700) | ||
| tree | 4c1136f834d85ca27f5f1870e46352d56927c249 | treesnapshot (tar.gz zip) |
| parent | d7416ecac8508367a8ac35ab74ef09b7707d0c4b | commitdiff |
send-email: make message-id generation a bit more robust
Earlier code took Unix time and appended a few random digits.
If you are firing off many messages within a second, you could
issue the same id to different messages, which is a no-no. If
you send out 31 messages within a single second, with random
integer taken out of rand(4200), you have about 10% chance of
producing the same message ID.
This fixes the problem by uses a prefix string which is
constant-per-invocation (time and pid), with a serial number for
each message generated by the process appended at the end.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Earlier code took Unix time and appended a few random digits.
If you are firing off many messages within a second, you could
issue the same id to different messages, which is a no-no. If
you send out 31 messages within a single second, with random
integer taken out of rand(4200), you have about 10% chance of
producing the same message ID.
This fixes the problem by uses a prefix string which is
constant-per-invocation (time and pid), with a serial number for
each message generated by the process appended at the end.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| git-send-email.perl | diffblobblamehistory |