| commit | 76e50f7fbccb9db4659f1e7fea55fc4d51144d7c | |
| author | Jeff King <peff@peff.net> | |
| Wed, 22 Mar 2023 17:37:17 +0000 (22 13:37 -0400) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Wed, 22 Mar 2023 22:37:08 +0000 (22 15:37 -0700) | ||
| tree | be5d5368518d778521419d22199b24fb01ae1120 | treesnapshot (tar.gz zip) |
| parent | 27d43aaaf50ef0ae014b88bba294f93658016a2e | commitdiff |
fast-export: drop const when storing anonymized values
We store anonymized values as pointers to "const char *", since they are
conceptually const to callers who use them. But they are actually
allocated strings whose memory is owned by the struct.
The ownership mismatch hasn't been a big deal since we never free() them
(they are held until the program ends), but let's switch them to "char *"
in preparation for changing that.
Since most code only accesses them via anonymize_str(), it can continue
to narrow them to "const char *" in its return value.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We store anonymized values as pointers to "const char *", since they are
conceptually const to callers who use them. But they are actually
allocated strings whose memory is owned by the struct.
The ownership mismatch hasn't been a big deal since we never free() them
(they are held until the program ends), but let's switch them to "char *"
in preparation for changing that.
Since most code only accesses them via anonymize_str(), it can continue
to narrow them to "const char *" in its return value.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/fast-export.c | diffblobblamehistory |