From 3af74cfb153e20277a1d22414f04249d90d34d5c Mon Sep 17 00:00:00 2001 From: Jim Hill Date: Sun, 21 Dec 2014 11:26:00 -0800 Subject: [PATCH] pre-push.sample: remove unnecessary and misleading IFS=' ' The sample hook explicitly sets IFS to SP and nothing else so that the "read" used in the per-ref while loop that iterates over " SP SP SP " records, where we know refs and sha1s will not have SPs, would split them correctly. While this is not wrong per-se, it is not necessary; because we know these fields do not contain HT or LF, either, we can simply leave IFS the default. This will also prevent those who cut and paste from this sample from getting bitten when they write things in the per-ref loop that need splitting with the default $IFS (e.g. use $(git rev-list ...) to produce one-record-per-line output). Signed-off-by: Jim Hill Signed-off-by: Junio C Hamano --- templates/hooks--pre-push.sample | 1 - 1 file changed, 1 deletion(-) diff --git a/templates/hooks--pre-push.sample b/templates/hooks--pre-push.sample index 69e3c67b00..6187dbf439 100755 --- a/templates/hooks--pre-push.sample +++ b/templates/hooks--pre-push.sample @@ -24,7 +24,6 @@ url="$2" z40=0000000000000000000000000000000000000000 -IFS=' ' while read local_ref local_sha remote_ref remote_sha do if [ "$local_sha" = $z40 ] -- 2.11.4.GIT