| commit | 782c030ea21f02a5dfab3fd023e14084ebeff4dc | |
| author | René Scharfe <l.s.r@web.de> | |
| Sat, 18 Nov 2017 10:20:04 +0000 (18 11:20 +0100) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Sat, 18 Nov 2017 11:38:40 +0000 (18 20:38 +0900) | ||
| tree | c8e55101eac5d31163c2ea5fa77ff433fbf20a52 | treesnapshot (tar.gz zip) |
| parent | 3b48045c6c73a51834a2f83440a30225485ee431 | commitdiff |
config: flip return value of write_section()
d9bd4cbb9cc (config: flip return value of store_write_*()) made
write_section() follow the convention of write(2) to return -1 on error
and the number of written bytes on success. 3b48045c6c7 (Merge branch
'sd/branch-copy') changed it back to returning 0 on error and 1 on
success, but left its callers still checking for negative values.
Let write_section() follow the convention of write(2) again to meet the
expectations of its callers.
Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
d9bd4cbb9cc (config: flip return value of store_write_*()) made
write_section() follow the convention of write(2) to return -1 on error
and the number of written bytes on success. 3b48045c6c7 (Merge branch
'sd/branch-copy') changed it back to returning 0 on error and 1 on
success, but left its callers still checking for negative values.
Let write_section() follow the convention of write(2) again to meet the
expectations of its callers.
Reported-by: Jeff King <peff@peff.net>
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| config.c | diffblobblamehistory |