| commit | 50250491bded3190e16978e836a4dbe129c632cf | |
| author | Jeff King <peff@peff.net> | |
| Mon, 18 Jan 2016 20:02:44 +0000 (18 15:02 -0500) | ||
| committer | Junio C Hamano <gitster@pobox.com> | |
| Tue, 19 Jan 2016 17:53:08 +0000 (19 09:53 -0800) | ||
| tree | a6c3b618bed2c01a503aa0a9b75bd053a8f0f564 | treesnapshot (tar.gz zip) |
| parent | 5c3894c39d4095e6875376a6c05c6390b9a50754 | commitdiff |
shortlog: use strbufs to read from stdin
We currently use fixed-size buffers with fgets(), which
could lead to incorrect results in the unlikely event that a
line had something like "Author:" at exactly its 1024th
character.
But it's easy to convert this to a strbuf, and because we
can reuse the same buffer through the loop, we don't even
pay the extra allocation cost.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We currently use fixed-size buffers with fgets(), which
could lead to incorrect results in the unlikely event that a
line had something like "Author:" at exactly its 1024th
character.
But it's easy to convert this to a strbuf, and because we
can reuse the same buffer through the loop, we don't even
pay the extra allocation cost.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| builtin/shortlog.c | diffblobblamehistory |