| commit | 12aa7456c937f758df9aafcc0123395ed7660fca | |
| author | Junio C Hamano <junkio@cox.net> | |
| Sat, 5 Nov 2005 07:50:09 +0000 (4 23:50 -0800) | ||
| committer | Junio C Hamano <junkio@cox.net> | |
| Sun, 6 Nov 2005 09:12:31 +0000 (6 01:12 -0800) | ||
| tree | 94058dbf8527bf42702a2ddf2b46f02420365428 | treesnapshot (tar.gz zip) |
| parent | 9e5d2b40967059dd5f35d02fba323751ef22ac4e | commitdiff |
Simplify CFLAGS/DEFINES in Makefile
I think the original intention was to make CFLAGS overridable
from the make command line, but somehow we ended up accumulating
conditional makefile sections that wrongly appends values to
CFLAGs. These assignments do not work when the user actually
override them from the make command line!
DEFINES are handled the same way; it was seemingly overridable,
but the makefile sections had assignments, which meant
overriding it from the command line broke things.
This simplifies things by limiting the internal futzing to
ALL_CFLAGS, and by removing DEFINES altogether. Overriding
CFLAGS from the command line should start working with this
change.
Signed-off-by: Junio C Hamano <junkio@cox.net>
I think the original intention was to make CFLAGS overridable
from the make command line, but somehow we ended up accumulating
conditional makefile sections that wrongly appends values to
CFLAGs. These assignments do not work when the user actually
override them from the make command line!
DEFINES are handled the same way; it was seemingly overridable,
but the makefile sections had assignments, which meant
overriding it from the command line broke things.
This simplifies things by limiting the internal futzing to
ALL_CFLAGS, and by removing DEFINES altogether. Overriding
CFLAGS from the command line should start working with this
change.
Signed-off-by: Junio C Hamano <junkio@cox.net>
| Makefile | diffblobblamehistory |