| commit | 9dc527adbc013b67cd85cce67bdccc3c10ed4792 | |
| author | Junio C Hamano <junkio@cox.net> | |
| Thu, 19 May 2005 06:34:03 +0000 (18 23:34 -0700) | ||
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | |
| Thu, 19 May 2005 14:31:23 +0000 (19 07:31 -0700) | ||
| tree | 7ec4c720ba190e5082ac7f1c809f24bedc0fd3c0 | treesnapshot (tar.gz zip) |
| parent | 9b632be30c72f25ac180fa2bf7286505c87e46d2 | commitdiff |
[PATCH] fix strbuf take #2
I just remembered why I placed that bogus "sb->len ==0 implies
sb->eof" condition there. We need at least something like this
to catch the normal EOF (that is, line termination immediately
followed by EOF) case. "if (feof(fp))" fires when we have
already read the eof, not when we are about read it.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
I just remembered why I placed that bogus "sb->len ==0 implies
sb->eof" condition there. We need at least something like this
to catch the normal EOF (that is, line termination immediately
followed by EOF) case. "if (feof(fp))" fires when we have
already read the eof, not when we are about read it.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| strbuf.c | diffblobblamehistory |