From cda8ab59bbdb24b4ef87083781dac1f4f1b973a1 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 23 Jun 2006 09:43:38 -0400 Subject: [PATCH] git-commit: allow -e option anywhere on command line Previously, the command 'git-commit -e -m foo' would ignore the '-e' option because the '-m' option overwrites the no_edit flag during sequential option parsing. Now we cause -e to reset the no_edit flag after all options are parsed. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- git-commit.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/git-commit.sh b/git-commit.sh index 6dd04fd367..e74fe640b8 100755 --- a/git-commit.sh +++ b/git-commit.sh @@ -199,6 +199,7 @@ only= logfile= use_commit= amend= +edit_flag= no_edit= log_given= log_message= @@ -246,7 +247,7 @@ do shift ;; -e|--e|--ed|--edi|--edit) - no_edit= + edit_flag=t shift ;; -i|--i|--in|--inc|--incl|--inclu|--includ|--include) @@ -384,6 +385,7 @@ $1" ;; esac done +case "$edit_flag" in t) no_edit= ;; esac ################################################################ # Sanity check options -- 2.11.4.GIT