From c0c35d5e419f3bf215103b1e26359aca288c2113 Mon Sep 17 00:00:00 2001 From: Linus Torvalds Date: Wed, 16 Nov 2005 09:38:46 -0800 Subject: [PATCH] Disallow empty pattern in "git grep" For some reason I've done a "git grep" twice with no pattern, which is really irritating, since it just grep everything. If I actually wanted that, I could do "git grep ^" or something. So add a "usage" message if the pattern is empty. Signed-off-by: Linus Torvalds Signed-off-by: Junio C Hamano --- git-grep.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/git-grep.sh b/git-grep.sh index e7a35ebd70..44c16130bd 100755 --- a/git-grep.sh +++ b/git-grep.sh @@ -39,5 +39,9 @@ while : ; do esac shift done +[ "$pattern" ] || { + echo >&2 "usage: 'git grep [pathspec*]'" + exit 1 +} git-ls-files -z "${git_flags[@]}" "$@" | xargs -0 grep "${flags[@]}" -e "$pattern" -- 2.11.4.GIT