From b85f69a8da01db1962fef4ea4acd061ce7440a5c Mon Sep 17 00:00:00 2001 From: Heiko Voigt Date: Thu, 22 Mar 2012 19:17:03 +0100 Subject: [PATCH] Windows: Always normalize paths to Windows-style It appears that `pwd` returns the POSIX-style or the DOS-style path depending which style the previous `cd` used. To normalize, enforce `pwd -W` in scripts. From the original e-mail exchange: On Thu, Mar 22, 2012 at 11:13:37AM +0100, Sebastian Schuberth wrote: > On Wed, Mar 21, 2012 at 22:21, Johannes Sixt wrote: > > > I build git and run its tests outside the msysgit environment. Does that > > explain the difference? (And I use CMD.) > > It does not make a difference for me. I started cmd.exe at > c:\msysgit\git\t, added c:\msysgit\bin temporarily to PATH, and ran > "sh t5526-fetch-submodules.sh -i -v", and the test still fails. Yes it probably does. Johannes said that he runs the tests outside of the msysgit folder. That way there is only one path the submodule script gets reported and not two like '/c/msysgit/git' and '/git'. That would explain to me why it is passing. I am afraid that the only solution is to patch msys itself to report the long absolute path when passing window style paths to cd. Currently when I do cd c:/msysgit/git I will end up in '/git' instead of the long path. I found that there is a -W option to pwd in msys bash which makes it always return the real windows path. A normalization in that direction is unique and thus might be more robust. Have a look at the attached patch. With this at least t5526 passes. I was not able to run the whole testsuite properly at the moment. I can have a look at that tomorrow. What do you think? Cheers Heiko Signed-off-by: Johannes Schindelin --- git-sh-setup.sh | 6 ++---- git-submodule.sh | 3 --- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/git-sh-setup.sh b/git-sh-setup.sh index ee0e0bc045..0fa49b2d19 100644 --- a/git-sh-setup.sh +++ b/git-sh-setup.sh @@ -233,10 +233,8 @@ case $(uname -s) in find () { /usr/bin/find "$@" } - # git sees Windows-style pwd - pwd () { - builtin pwd -W - } + # Let pwd always return the uniqe real windows path + alias pwd='pwd -W' is_absolute_path () { case "$1" in [/\\]* | [A-Za-z]:*) diff --git a/git-submodule.sh b/git-submodule.sh index ab6b1107b6..595811f319 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -215,9 +215,6 @@ module_clone() # resolve any symlinks that might be present in $PWD a=$(cd_to_toplevel && cd "$gitdir" && pwd)/ b=$(cd_to_toplevel && cd "$sm_path" && pwd)/ - # normalize Windows-style absolute paths to POSIX-style absolute paths - case $a in [a-zA-Z]:/*) a=/${a%%:*}${a#*:} ;; esac - case $b in [a-zA-Z]:/*) b=/${b%%:*}${b#*:} ;; esac # Remove all common leading directories after a sanity check if test "${a#$b}" != "$a" || test "${b#$a}" != "$b"; then die "$(eval_gettext "Gitdir '\$a' is part of the submodule path '\$b' or vice versa")" -- 2.11.4.GIT